-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tests to include Exasol V8/ Update to vsjdbc 12.0.0 / Fix issues #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated dependencies - changed default DB version used to run CI tests - ran PK and artifact unifier tool
according to strict data type checking
…ted to strict datatype checks in the compiler
… the case of char and varchar datatypes
…ittle to no purpose, the assumeV7 indicator is enough.
pj-spoelders
changed the title
Refactor/add v8 to ci
Updated tests to include Exasol V8/ Update to vsjdbc 12.0.0 / Fix issues
Mar 28, 2024
kaklakariada
requested changes
Apr 2, 2024
src/main/java/com/exasol/adapter/dialects/exasol/ExasolLocalSqlGenerationVisitor.java
Show resolved
Hide resolved
src/main/java/com/exasol/adapter/dialects/exasol/ExasolLocalSqlGenerationVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exasol/adapter/dialects/exasol/ExasolLocalSqlGenerationVisitor.java
Outdated
Show resolved
Hide resolved
src/test/java/com/exasol/adapter/dialects/exasol/AbstractExasolSqlDialectIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Pirkl <[email protected]>
Improved documentation on data type mismatches.
kaklakariada
requested changes
Apr 2, 2024
src/main/java/com/exasol/adapter/dialects/exasol/ExasolLocalSqlGenerationVisitor.java
Outdated
Show resolved
Hide resolved
kaklakariada
previously approved these changes
Apr 2, 2024
Quality Gate passedIssues Measures |
kaklakariada
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105
Closes #117